[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 28 06:48:31 PDT 2018


hokein added a comment.

> Could we try to figure out why the duplicates were there in the first place and why the paths were different?

+1, I think there are two issues here:

1. the result contains two candidates, which should be one, IIUC.
2. the absolute file path problem, we encountered similar problem in SymbolCollector, and we have similar function `ToURI` there, I think we can share the implementation instead of having different duplications.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D48687





More information about the cfe-commits mailing list