[PATCH] D48493: [HIP] Support flush denorms bitcode

[Aaron Enye Shi via Phabricator via cfe-commits]

ashi1 updated this revision to Diff 153146.
ashi1 added a comment.

Merged checks for flush denorm on and off into single test hip-device-libs.hip


https://reviews.llvm.org/D48493

Files:
  lib/Driver/ToolChains/HIP.cpp
  test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc
  test/Driver/Inputs/hip_dev_lib/ockl.amdgcn.bc
  test/Driver/Inputs/hip_dev_lib/oclc_correctly_rounded_sqrt_on.amdgcn.bc
  test/Driver/Inputs/hip_dev_lib/oclc_daz_opt_off.amdgcn.bc
  test/Driver/Inputs/hip_dev_lib/oclc_daz_opt_on.amdgcn.bc
  test/Driver/Inputs/hip_dev_lib/oclc_finite_only_off.amdgcn.bc
  test/Driver/Inputs/hip_dev_lib/oclc_isa_version_803.amdgcn.bc
  test/Driver/Inputs/hip_dev_lib/oclc_isa_version_900.amdgcn.bc
  test/Driver/Inputs/hip_dev_lib/oclc_unsafe_math_off.amdgcn.bc
  test/Driver/Inputs/hip_dev_lib/ocml.amdgcn.bc
  test/Driver/Inputs/hip_dev_lib/opencl.amdgcn.bc
  test/Driver/hip-device-libs.hip


Index: test/Driver/hip-device-libs.hip
===================================================================
--- test/Driver/hip-device-libs.hip
+++ test/Driver/hip-device-libs.hip
@@ -0,0 +1,27 @@
+// REQUIRES: clang-driver
+// REQUIRES: x86-registered-target
+// REQUIRES: amdgpu-registered-target
+
+// Test flush-denormals-to-zero enabled uses oclc_daz_opt_on
+
+// RUN: %clang -### -target x86_64-linux-gnu \
+// RUN:   -x hip --cuda-gpu-arch=gfx900 \
+// RUN:   --hip-device-lib-path=%S/Inputs/hip_dev_lib \
+// RUN:   -fcuda-flush-denormals-to-zero \
+// RUN:   %S/Inputs/hip_multiple_inputs/b.hip \
+// RUN: 2>&1 | FileCheck %s --check-prefixes=COM,FLUSHD
+
+// Test flush-denormals-to-zero disabled uses oclc_daz_opt_off
+
+// RUN: %clang -### -target x86_64-linux-gnu \
+// RUN:   -x hip --cuda-gpu-arch=gfx900 \
+// RUN:   --hip-device-lib-path=%S/Inputs/hip_dev_lib \
+// RUN:   %S/Inputs/hip_multiple_inputs/b.hip \
+// RUN: 2>&1 | FileCheck %s --check-prefixes=COM,NOFLUSHD
+
+
+// COM: [[LLVM_LINK:"*.llvm-link"]]
+// FLUSHD-SAME: {{.*}} "{{.*}}oclc_daz_opt_on.amdgcn.bc"
+// NOFLUSHD-SAME: {{.*}} "{{.*}}oclc_daz_opt_off.amdgcn.bc"
+// COM-SAME: {{.*}} "-o" "{{.*}}-gfx900-linked-{{.*bc}}"
+
Index: lib/Driver/ToolChains/HIP.cpp
===================================================================
--- lib/Driver/ToolChains/HIP.cpp
+++ lib/Driver/ToolChains/HIP.cpp
@@ -75,10 +75,16 @@
     std::string ISAVerBC =
         "oclc_isa_version_" + SubArchName.drop_front(3).str() + ".amdgcn.bc";

+    llvm::StringRef FlushDenormalControlBC;
+    if (Args.hasArg(options::OPT_fcuda_flush_denormals_to_zero))
+      FlushDenormalControlBC = "oclc_daz_opt_on.amdgcn.bc";
+    else
+      FlushDenormalControlBC = "oclc_daz_opt_off.amdgcn.bc";
+
     BCLibs.append({"opencl.amdgcn.bc",
                    "ockl.amdgcn.bc", "irif.amdgcn.bc", "ocml.amdgcn.bc",
                    "oclc_finite_only_off.amdgcn.bc",
-                   "oclc_daz_opt_off.amdgcn.bc",
+                   FlushDenormalControlBC,
                    "oclc_correctly_rounded_sqrt_on.amdgcn.bc",
                    "oclc_unsafe_math_off.amdgcn.bc", ISAVerBC});
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48493.153146.patch
Type: text/x-patch
Size: 2150 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180627/9faac022/attachment.bin>