[PATCH] D48616: Implement LWG 2946, 3075 and 3076

[Louis Dionne via Phabricator via cfe-commits]

ldionne added a comment.

More missed `noexcept`s.



================
Comment at: include/string:279
+    template <class T>
+        size_type find_first_of(const T& t, size_type pos = 0) const noexcept; // C++17
     size_type find_first_of(const value_type* s, size_type pos, size_type n) const noexcept;
----------------
I think you need to remove this `noexcept`.


================
Comment at: include/string:286
+    template <class T>
+        size_type find_last_of(const T& t, size_type pos = npos) const noexcept;  // C++17
     size_type find_last_of(const value_type* s, size_type pos, size_type n) const noexcept;
----------------
Remove `noexcept`.


================
Comment at: include/string:293
+    template <class T>
+        size_type find_first_not_of(const T& t, size_type pos = 0) const noexcept; // C++17
     size_type find_first_not_of(const value_type* s, size_type pos, size_type n) const noexcept;
----------------
Remove `noexcept`.


================
Comment at: include/string:307
+    template <class T>
+        int compare(const T& t) const noexcept;  // C++17
     int compare(size_type pos1, size_type n1, const basic_string& str) const;
----------------
Remove `noexcept`.


https://reviews.llvm.org/D48616