[PATCH] D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 27 09:05:11 PDT 2018
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from some documentation nits.
================
Comment at: docs/clang-tidy/checks/misc-unused-parameters.rst:6
-Finds unused parameters and fixes them, so that `-Wunused-parameter` can be
-turned on.
+Finds unused function parameters. Unused parameters may signal about a bug in
+the code (e.g. when a different parameter is used instead). The suggested fixes
----------------
may signal about a bug -> may signify a bug
================
Comment at: docs/clang-tidy/checks/misc-unused-parameters.rst:42
+ an unused parameter is unlikely to be unnoticed by a human reader, and
+ there's basically no place for a bug to hide in.
----------------
to hide in -> to hide
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46951
More information about the cfe-commits
mailing list