[PATCH] D48368: [clangd] Sema ranking tweaks: downrank keywords and injected names.

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

The code looks good to me.

It'd be nicer if you can put ranking screenshots (before vs after) in the patch summary.



================
Comment at: clangd/Quality.cpp:160
+    case Keyword:  // Often relevant, but misses most signals.
+      Score *= 4;  // FIXME: important keywords should have specific boosts.
       break;
----------------
I'm curious on how we choose these magic numbers, by experience?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D48368