[PATCH] D48524: [ODRHash] Do not put elaborated types in the TypeMap

[Richard Trieu via Phabricator via cfe-commits]

rtrieu added a comment.

Hey Vassil,

I have been giving this a little more thought and I have a solution I'd like you to try out.  If the type pointers aren't unique enough, then the indexing scheme will not work for hashing.  Can you try this idea in your build environment and see if works for you?  That is,  use this version AddType:

  void ODRHash::AddType(const Type *T) {
    assert(T && "Expecting non-null pointer.");
  
    ODRTypeVisitor(ID, *this).Visit(T);
  }

If the recursion issue that originally made the indexing scheme necessary is no longer present, then this would be path forward for ODR Hashing.


Repository:
  rC Clang

https://reviews.llvm.org/D48524