[PATCH] D48436: [analyzer][UninitializedObjectChecker] Fixed a false negative by no longer filtering out certain constructor calls

George Karpenkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 26 17:46:39 PDT 2018


george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:674
+  const LocationContext *LC = Context.getLocationContext();
+  while ((LC = LC->getParent())) {
+
----------------
nit: could we have `while (LC)` followed by `LC = LC->getParent()` ? Do you intentionally skip the first location context?


https://reviews.llvm.org/D48436





More information about the cfe-commits mailing list