[PATCH] D48616: Implement LWG 2946, 3075 and 3076

[Stephan T. Lavavej via Phabricator via cfe-commits]

STL_MSFT added inline comments.


================
Comment at: test/std/strings/basic.string/string.cons/string_view_deduction.fail.cpp:26
+//  The deduction guide shall not participate in overload resolution if Allocator is
+//  is a type that does not qualify as an allocator.
+
----------------
Repeated "is", occurs repeatedly in other files.


================
Comment at: test/std/strings/basic.string/string.cons/string_view_deduction.fail.cpp:37
+    {
+    std::string_view sv = "12345678901234";
+    std::basic_string s1{sv, 23}; // 23 is not an allocator!
----------------
You need to include `<string_view>`, occurs in other files.


================
Comment at: test/std/strings/basic.string/string.cons/string_view_deduction.pass.cpp:32
+#include <cassert>
+#include <cstddef>
+
----------------
You technically need `<memory>` for std::allocator, `<type_traits>` for std::is_same_v.


================
Comment at: test/std/strings/basic.string/string.nonmembers/string.special/swap_noexcept.pass.cpp:38
     some_alloc(const some_alloc&);
+	T *allocate(size_t);
     void deallocate(void*, unsigned) {}
----------------
Weird indentation here - is there a tab instead of spaces? Occurs below.


https://reviews.llvm.org/D48616