[PATCH] D45454: Make __gcov_flush visible outside a shared library

Stephen Hines via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 26 14:43:56 PDT 2018


srhines added a comment.

In https://reviews.llvm.org/D45454#1144099, @davidxl wrote:

> GCC's behavior is not documented and it also has changed over the years.
>
> Unless there is a bug, changing LLVM's gcov_flush visibility can potentially break clients that depend on this behavior.


I think that's the issue though. LLVM changed visibility of this function recently too. We had Android code depending on this function being visible, and that broke.


https://reviews.llvm.org/D45454





More information about the cfe-commits mailing list