[PATCH] D48241: [DebugInfo] Emit ObjC methods as part of interface.

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 26 10:46:16 PDT 2018


aprantl added inline comments.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4239
+    // Add methods to interface.
+    for (auto p : ObjCMethodCache) {
+      if (p.second.empty())
----------------
JDevlieghere wrote:
> dexonsmith wrote:
> > Some comment for "p" here.
> Fixed; I'll update the rest of the file in a follow-up to keep things consistent.
Unfortunately CFE doesn't seem to consistently use the LLVM coding style: A lot of CFE developers seem to prefer lower-case variable names. I don't know if that is a historic artifact or a conscious decision.


https://reviews.llvm.org/D48241





More information about the cfe-commits mailing list