[PATCH] D48562: [clangd] XPC transport layer

[Jan Korous via Phabricator via cfe-commits]

jkorous added inline comments.


================
Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51
+          dlHandle, "clangd_xpc_get_bundle_identifier");
+  xpc_connection_t conn =
+      xpc_connection_create(clangd_xpc_get_bundle_identifier(), NULL);
----------------
arphaman wrote:
> We should probably use the main queue here too to ensure that we don't get bit by concurrent handler invocations. 
As far as I understand it this is taken care of by calling dispatch_main().

Per man dispatch_main:
"MAIN QUEUE
[...]
     Programs must call dispatch_main() at the end of main() in order to process blocks submitted to the main queue."



Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D48562