[PATCH] D48100: Append new attributes to the end of an AttributeList.

[Eric Christopher via Phabricator via cfe-commits]

echristo added subscribers: dlj, echristo.
echristo added a comment.

I've added a couple of inline comments here - between this and the comments in the post-commit review from dlj it seems like we might want to revert this for now and figure out the best way forward.

Thanks!

-eric



================
Comment at: test/Sema/attr-micromips.c:9
 
-__attribute__((micromips,mips16)) void foo5();  // expected-error {{'micromips' and 'mips16' attributes are not compatible}} \
+__attribute__((micromips,mips16)) void foo5();  // expected-error {{'mips16' and 'micromips' attributes are not compatible}} \
                                                 // expected-note {{conflicting attribute is here}}
----------------
This seems to reverse? What's going on here? There are other occurrences too.


================
Comment at: test/Sema/attr-target-mv.c:98
 int __attribute__((target("sse4.2"))) diff_cc(void);
-// expected-error at +1 {{multiversioned function declaration has a different calling convention}}
+// expected-error at +1 {{attribute 'target' multiversioning cannot be combined with other attributes}}
 __vectorcall int __attribute__((target("arch=sandybridge")))  diff_cc(void);
----------------
This appears to have broken a particular error message?


Repository:
  rC Clang

https://reviews.llvm.org/D48100