[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

Momchil Velikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 25 02:14:47 PDT 2018


chill added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:5055
+      Alignment = getContext().getTypeNaturalAlign(Ty);
+      Alignment = std::min(std::max(Alignment, 64u), 128u);
+    } else {
----------------
t.p.northover wrote:
> I think the max/min logic is more confusing here than the alternative:
> 
>     Alignment = Alignment < 128 ? 64 : 128;
I'll change it.


https://reviews.llvm.org/D46013





More information about the cfe-commits mailing list