[PATCH] D47673: [Coroutines] Less IR for noexcept await_resume
Gor Nishanov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Jun 23 09:53:23 PDT 2018
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM with some suggestions.
================
Comment at: lib/CodeGen/CGCoroutine.cpp:224
+ bool ResumeCanThrow = true;
+ if (const auto *MCE = dyn_cast<CXXMemberCallExpr>(S.getResumeExpr()))
+ if (const auto *Proto =
----------------
This long sequence of if statements seems to be asking to be put into its own predicate function: expressionCanThrow or something like that.
Repository:
rC Clang
https://reviews.llvm.org/D47673
More information about the cfe-commits
mailing list