[PATCH] D48493: [HIP] Support flush denorms bitcode

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 22 11:01:58 PDT 2018


yaxunl added a comment.

I think we should have a lit test for linked bitcode files.



================
Comment at: lib/Driver/ToolChains/HIP.cpp:78
+    std::string OCLC_daz_opt;
+    if (Args.hasArg(options::OPT_fcuda_flush_denormals_to_zero))
+      OCLC_daz_opt = "oclc_daz_opt_on.amdgcn.bc";
----------------
you can use StringRef here. Please use a more meaningful name, e.g. FlushDenormalControlBC.


Repository:
  rC Clang

https://reviews.llvm.org/D48493





More information about the cfe-commits mailing list