[PATCH] D47698: [ASTImporter] import macro source locations

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 22 07:56:18 PDT 2018


martong added a comment.

In https://reviews.llvm.org/D47698#1140629, @thakis wrote:

> This code is live when reading pchs, correct? Does this have any measurable perf impact on deserializing pchs for, say, Cocoa.h or Windows.h?


No. The deserialization of a PCH is handled in a completely independent source code. ASTImporter is responsible to merge two ASTs. These ASTs may come from a PCH - deserialized - , or they may be provided by the parser; from the ASTImporer's point of view this is irrelevant. Thus, there is no performance impact on deserialization of PCHs.


Repository:
  rC Clang

https://reviews.llvm.org/D47698





More information about the cfe-commits mailing list