[PATCH] D48443: [WIP] Add no-prototype attribute to prototype-less C functions

Derek Schuff via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 21 14:10:14 PDT 2018


dschuff added inline comments.


================
Comment at: lib/CodeGen/CGCall.cpp:1850
+        FuncAttrs.addAttribute("no-prototype");
       AddAttributesFromFunctionProtoType(
           getContext(), FuncAttrs, Fn->getType()->getAs<FunctionProtoType>());
----------------
Would it make sense to put this in `AddAttributesFormFunctionProtoType` Does this have the same effect as that would? For that matter, what's the practical difference between this call and the one on line 1826?


Repository:
  rC Clang

https://reviews.llvm.org/D48443





More information about the cfe-commits mailing list