[PATCH] D48426: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801)

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 21 10:19:58 PDT 2018


thakis added inline comments.


================
Comment at: lib/AST/ASTContext.cpp:9563
+    if (getExternalSource()->DeclIsFromPCHWithObjectFile(D))
+      return false;
+  }
----------------
It'd be good to add a comment (and a test) explaining why / how _referenced_ inline functions still get emitted for inlining.


https://reviews.llvm.org/D48426





More information about the cfe-commits mailing list