[PATCH] D48418: [clangd] Expose 'shouldCollectSymbol' helper from SymbolCollector.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 21 03:16:37 PDT 2018


sammccall added a comment.

Can you motivate this change a bit, and add tests?



================
Comment at: clangd/index/SymbolCollector.h:61
+  /// AST matchers require non-const ASTContext.
+  static bool shouldCollectSymbol(const NamedDecl &ND, ASTContext &ASTCtx);
+
----------------
in principle, this should take const Options&?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D48418





More information about the cfe-commits mailing list