[PATCH] D46485: Add python tool to dump and construct header maps

[Stella Stamenova via Phabricator via cfe-commits]

stella.stamenova added a comment.

This breaks the clang tests on Windows when building using Visual Studio as none of the updated tests can find hmaptool.

Visual Studio as a generator supports multiple configurations, so its bin folder varies depending on the build configuration. The generalized version of the bin directory is: ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin. This is actually the proper bin directory to use for any generator because ${CMAKE_CFG_INTDIR} is simply '.' when the generator (such as ninja) doesn't support multiple configurations.

I can look into a fix and submit a change for review tomorrow if you can't, but in the future please make sure to use the full path to the bin directory (${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) to avoid missing a generator.


Repository:
  rC Clang

https://reviews.llvm.org/D46485