r335159 - Fixed test in prior build where FileCheck tried to match against

via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 20 12:55:32 PDT 2018


(Using the right commits list this time...)

See inline (same as previous).

> -----Original Message-----
> From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org] On Behalf Of
> Leonard Chan via cfe-commits
> Sent: Wednesday, June 20, 2018 3:34 PM
> To: cfe-commits at lists.llvm.org
> Subject: r335159 - Fixed test in prior build where FileCheck tried to
> match against
> 
> Author: leonardchan
> Date: Wed Jun 20 12:34:05 2018
> New Revision: 335159
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=335159&view=rev
> Log:
> Fixed test in prior build where FileCheck tried to match against
> `common` when declaring a global variable when we primarily care about
> the value assigned in the test.
> 
> Modified:
>     cfe/trunk/test/Frontend/fixed_point_declarations.c
> 
> Modified: cfe/trunk/test/Frontend/fixed_point_declarations.c
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/Frontend/fixed_point_declarations.c?rev=335159&r1=3
> 35158&r2=335159&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Frontend/fixed_point_declarations.c (original)
> +++ cfe/trunk/test/Frontend/fixed_point_declarations.c Wed Jun 20 12:34:05
> 2018
> @@ -1,4 +1,4 @@
> -// RUN: %clang -ffixed-point -S -emit-llvm %s -o - | FileCheck %s
> +// RUN: %clang -ffixed-point -S -emit-llvm %s -o - --target=x86_64-linux
> | FileCheck %s
>  // RUN: %clang -ffixed-point -S -emit-llvm %s -o - --target=x86_64-scei-
> ps4-ubuntu-fast | FileCheck %s

By the way, "x86_64-scei-ps4-ubuntu-fast" is not a real triple.  The PS4
triple is "x86_64-scei-ps4" (although there is an ubuntu-fast bot, which
might be where the confusion arises).

Is there any particular reason to want to use the PS4 triple in addition
to Linux?  I haven't really been watching the fixed-point stuff.
Thanks,
--paulr
PS4 code owner

> 
>  // Primary fixed point types
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list