[PATCH] D34156: [LTO] Enable module summary emission by default for regular LTO

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson accepted this revision.
tejohnson added a comment.

LGTM with following suggestions.



================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:776
+  bool EmitLTOSummary =
+      (CodeGenOpts.PrepareForLTO && !CodeGenOpts.PrepareForThinLTO &&
+       llvm::Triple(TheModule->getTargetTriple()).getVendor() !=
----------------
Perhaps sink all this code into the use site of EmitLTOSummary below, especially because you don't need to check !CodeGenOpts.PrepareForThinLTO.


================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:998
+  bool EmitLTOSummary =
+      (CodeGenOpts.PrepareForLTO && !CodeGenOpts.PrepareForThinLTO &&
+       llvm::Triple(TheModule->getTargetTriple()).getVendor() !=
----------------
Ditto here.


https://reviews.llvm.org/D34156