[PATCH] D47953: [builtin] Add bitfield support for __builtin_dump_struct

[Paul Semel via Phabricator via cfe-commits]

paulsemel added a comment.

I will for sure add tests @lebedev.ri . Fact is that, for the moment, this is not working as expected.
This is why I am asking for a bit of help about this bitfield handling :)



================
Comment at: lib/CodeGen/CGBuiltin.cpp:1250
+      if (Info.IsSigned) {
+        unsigned HighBits = Info.StorageSize - Info.Offset - Info.Size;
+        if (HighBits)
----------------
aaron.ballman wrote:
> What happens if this overflows due to being < 0?
How could this be < 0 ?
If it is, it means that there was a problem during bitfield construction isn't it ?
I mean StorageSize is always greater that Offset + Size


Repository:
  rC Clang

https://reviews.llvm.org/D47953