[PATCH] D48106: implemented proto to llvm

[Emmett Neyman via Phabricator via cfe-commits]

emmettneyman added inline comments.


================
Comment at: tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:71
+    return val_var;
+  }
+}
----------------
morehouse wrote:
> Is it still possible for the protobuf to not have a constant, a binOp, or a varRef?
Right now, since the protobufs use `oneof`, it is possible for the protobuf to not have a constant binOp, or varRef. For now, I'll generate "dummy" code for this case. 

Then, I'll submit a new patch that eliminates the use of `oneof` for both `cxx_proto.proto` and `cxx_loop_proto` so that "dummy" code isn't necessary.


Repository:
  rC Clang

https://reviews.llvm.org/D48106