[PATCH] D48106: implemented proto to llvm

Matt Morehouse via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 19 11:02:31 PDT 2018


morehouse added inline comments.


================
Comment at: tools/clang-fuzzer/handle-llvm/CMakeLists.txt:5
+  handle_llvm.cpp
+  )
----------------
emmettneyman wrote:
> morehouse wrote:
> > There's fewer libraries linked here than in `handle-cxx/` (not saying this is wrong, but it could be).  Do you get link errors if you build `clang-llvm-proto-fuzzer` with shared libraries?
> It builds without any errors both with all the libraries from `handle-cxx/` linked in and without any of the libraries linked in (as I have here). Which is preferred?
I prefer what you have here, if shared libraries are OK.


Repository:
  rC Clang

https://reviews.llvm.org/D48106





More information about the cfe-commits mailing list