[PATCH] D48188: [SPIR] Prevent SPIR targets from using half conversion intrinsics

Sjoerd Meijer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 19 00:58:45 PDT 2018


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks OK to me.



================
Comment at: test/CodeGen/spir-half-type.cpp:89
+
+_Float16 fadd() {
+  _Float16 a = 1.0f16;
----------------
Nit: let one of these functions take a _Float16 function argument?


https://reviews.llvm.org/D48188





More information about the cfe-commits mailing list