[PATCH] D48266: [Driver] Add -fno-digraphs

Jacob Bandes-Storch via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 18 12:53:23 PDT 2018


jtbandes marked an inline comment as done.
jtbandes added inline comments.


================
Comment at: include/clang/Driver/Options.td:1337-1338
     Flags<[CC1Option]>, Group<f_Group>;
+def fno_digraphs : Flag<["-"], "fno-digraphs">, Group<f_Group>, Flags<[CC1Option]>,
+  HelpText<"Disallow alternative token representations '<:', ':>', '<%', '%>', '%:'">;
 def fno_declspec : Flag<["-"], "fno-declspec">, Group<f_clang_Group>,
----------------
rsmith wrote:
> In the driver, we generally want a `-ffoo` option matching `-fno-foo`. That is, the driver (but not `-cc1`) should support a matching `-fdigraphs` option to undo the effect of `-fno-digraphs`, unless there's a good reason not to do so.
Didn't find a great place to put this option; I'm not sure what this file's organization scheme is supposed to be.


Repository:
  rC Clang

https://reviews.llvm.org/D48266





More information about the cfe-commits mailing list