[PATCH] D47988: [CodeGen] Emit MSVC funclet IR for Obj-C exceptions

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 18 11:33:35 PDT 2018


rjmccall added a comment.

In general, it's unfortunate that this has to leave so many C++-runtime-specific tendrils in the ObjC code.  Unlike the EH type patch, though, I'm not sure I can see a great alternative here, especially because of the semantic restrictions required by outlining.



================
Comment at: lib/CodeGen/CGCXXABI.h:248
+    llvm_unreachable("Only needed for the Microsoft ABI");
+  }
 
----------------
Should you just generalize the existing method to only take a VarDecl* so it can be used for either kind of catch?


Repository:
  rC Clang

https://reviews.llvm.org/D47988





More information about the cfe-commits mailing list