[PATCH] D48169: [mips] Add '-mcrc', '-mno-crc' options to enable/disable CRC ASE

[Simon Atanasyan via Phabricator via cfe-commits]

atanasyan accepted this revision.
atanasyan added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/clang/Driver/Options.td:2214
   HelpText<"Disable SVR4-style position-independent code (Mips only)">;
+def mno_crc : Flag<["-"], "mno-crc">, Group<m_mips_Features_Group>,
+  HelpText<"Disallow use of CRC instructions (Mips only)">;
----------------
sdardis wrote:
> atanasyan wrote:
> > Does it make a sense to define this option as an alias to the `mnocrc` and allow to use both `-mno-crc` and `-mnocrc` for ARM and MIPS?
> I thought about commenting on that. The problem there is that you then permitting clang to be more lax than binutils which inhibits compatibility between the two tools.
> The problem there is that you then permitting clang to be more lax than binutils which inhibits compatibility between the two tools.

Good point. Agreed.




Repository:
  rC Clang

https://reviews.llvm.org/D48169