[PATCH] D48163: [clangd] UI for completion items that would trigger include insertion.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 15 06:35:53 PDT 2018
ioeric added inline comments.
================
Comment at: clangd/CodeComplete.h:63
- // Populated internally by clangd, do not set.
+ /// Populated internally by clangd, do not set.
/// If `Index` is set, it is used to augment the code completion
----------------
sammccall wrote:
> if you want this to be part of the doc comment, move it to the bottom?
>
> I think the intent was that this comment apply to all following members. So keeping the line as `//` and adding the new member above it would also make sense
Ohh, didn't know this was intentional. Done.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48163
More information about the cfe-commits
mailing list