[PATCH] D48163: [clangd] UI for completion items that would trigger include insertion.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 15 06:17:07 PDT 2018


sammccall added inline comments.


================
Comment at: clangd/CodeComplete.cpp:313
+    I.label =
+        (InsertingInclude ? Opts.IncludeInsertionIndicator : " ") + I.label;
     I.scoreInfo = Scores;
----------------
sammccall wrote:
> string(IncludeInsertionIndicator.size(), ' ')?
oops, I made the same mistake - #bytes in the indicator != width of the indicator.

maybe making this customizable is too much hassle


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D48163





More information about the cfe-commits mailing list