[PATCH] D48163: [clangd] UI for completion items that would trigger include insertion.

[Eric Liu via Phabricator via cfe-commits]

ioeric added a comment.

Thanks for the review!



================
Comment at: clangd/CodeComplete.cpp:187
+  // Whether or not this candidate is in a completion where index is allowed.
+  // This can affect how items are built (e.g. indent label to align with visual
+  // indicator in index results).
----------------
sammccall wrote:
> Hmm, I'm not sure this should be conditional.
> Especially in editors that render [icon]label, inconsistently having a space or not for no obvious reason seems disorienting to users.
> 
> And it adds some complexity (especially in conjunction with bundling...)
Sure. I wasn't sure about this and wanted get your opinion before fixing tests.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D48163