[PATCH] D47957: [clangd] Add option to fold overloads into a single completion item.

[Sam McCall via Phabricator via cfe-commits]

sammccall marked 4 inline comments as done.
sammccall added inline comments.


================
Comment at: clangd/CodeComplete.cpp:245
+        // Methods are simply grouped by name.
+        return hash_combine('M', IndexResult->Name);
+      case index::SymbolKind::Function:
----------------
ilya-biryukov wrote:
> Members never come from the index for completion, right? Maybe add an assert here instead?
Done.
I'd keep the actual return here as it's simple and explains the value. We likely want to use it in future to augment members with signals from the index.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D47957