[PATCH] D48163: [clangd] UI for completion items that would trigger include insertion.

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

Ooh, bikeshed first!



================
Comment at: clangd/CodeComplete.cpp:278
+    if (AllowIndexCompletion)
+      I.label = (InsertingInclude ? "+" : " ") + I.label;
     I.scoreInfo = Scores;
----------------
I think we should avoid tokens that occur commonly in C++ (possibly with the exception of # which is used for this purpose. We should also avoid doublewide chars because of alignment (even assuming a monospace font is risky...)

Ideas:
- something like "external link" icon on wikipedia - but no such thing in unicode :-(🔗(U+1F517 link) looks truly terrible in at least some fonts
- variant on plus like ⊕ (U+2295 circled plus) - can't find one I like a lot
- some kind of arrow like ☇ (U+2607 lightning) or ⇱ (U+21F1 north west arrow to corner) or ⮣ (upwards triangle-headed arrow with long head rightwards)
- variant on hash like ﹟(U+FE5F  small number sign)
- something unrelated but "special" like ※ (U+203B reference mark)

I'm not really happy with any of these :-(


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D48163