[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

[Nico Weber via Phabricator via cfe-commits]

thakis added inline comments.


================
Comment at: clang/lib/Sema/SemaDecl.cpp:6597
+          (getLangOpts().CPlusPlus17 ||
+           Context.getTargetInfo().getCXXABI().isMicrosoft()))
         NewVD->setImplicitlyInline();
----------------
Is this related to /Zc:externConstexpr / PR36413? If so, maybe we should do the standards-conforming thing by default and ask people to pass /Zc:externConstexpr- if they need ABI compat?

Want to add a FIXME about doing this in the AST in the source too?


https://reviews.llvm.org/D47956