[PATCH] D45202: [X86] Replacing X86-specific floor and ceil vector intrinsics with generic LLVM intrinsics

Sanjay Patel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 8 12:25:40 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D45202#1126616, @craig.topper wrote:

> I'm not sure whether we should be doing this here or in InstCombine. @spatel, what do you think?


It's been a while since I looked at these. Last memory I have is for the conversion from x86 masked ops to the generic LLVM intrinsics, and we did that in InstCombineCalls. I don't know if there was any sound reasoning for that though. If it makes no functional difference, I'd continue with that structure just so we don't become scattered in the transform.


https://reviews.llvm.org/D45202





More information about the cfe-commits mailing list