[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: include/clang/Basic/DiagnosticGroups.td:264-265
 def LogicalOpParentheses: DiagGroup<"logical-op-parentheses">;
+def LogicalOpParenthesesInMacros: DiagGroup<"logical-op-parentheses-in-macros">;
 def LogicalNotParentheses: DiagGroup<"logical-not-parentheses">;
 def ShiftOpParentheses: DiagGroup<"shift-op-parentheses">;
----------------
lebedev.ri wrote:
> lebedev.ri wrote:
> > `LogicalOpParenthesesInMacros` should be in `LogicalNotParentheses` group.
> That should have of course been: `LogicalOpParenthesesInMacros` should be in `LogicalOpParentheses` group.
Are you sure you are uploading the correct diff?
Neither of these two notes is done.


https://reviews.llvm.org/D47687