[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Xing via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 8 02:15:45 PDT 2018


Higuoxing updated this revision to Diff 150465.
Higuoxing added a comment.

I step out a little further... I made an attempt to add a new warning `[-Wlogical-op-parentheses-in-macros]`. Comparing to the previous one, which do you prefer? I am new to llvm community, and as you see, this is my first patch ... so, forgive me if I made something wrong : ) suggestions are welcoming!

PS. I see something like `(x | y & z)` checking disabled in macros as well, how to deal with this?

thanks


https://reviews.llvm.org/D47687

Files:
  include/clang/Basic/DiagnosticGroups.td
  include/clang/Basic/DiagnosticSemaKinds.td
  lib/Sema/SemaExpr.cpp
  test/Sema/parentheses.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47687.150465.patch
Type: text/x-patch
Size: 5640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180608/74e3efe1/attachment.bin>


More information about the cfe-commits mailing list