[PATCH] D34156: [LTO] Enable module summary emission by default for regular LTO

[Vlad Tsyrklevich via Phabricator via cfe-commits]

vlad.tsyrklevich added a comment.
Herald added a subscriber: steven_wu.

Hi Tobias, I tracked down the failure self-hosting LLVM with LTO with this revision to https://bugs.llvm.org/show_bug.cgi?id=37684#c2 and have a fix under review in https://reviews.llvm.org/D47898. This revision needs to be updated to include the following trivial EmitSummaryIndex->PrepareForThinLTO renames to build:

  --- a/lib/CodeGen/BackendUtil.cpp
  +++ b/lib/CodeGen/BackendUtil.cpp
  @@ -944,7 +944,7 @@ void EmitAssemblyHelper::EmitAssemblyWithNewPassManager(
     ModulePassManager MPM(CodeGenOpts.DebugPassManager);
   
     if (!CodeGenOpts.DisableLLVMPasses) {
  -    bool IsThinLTO = CodeGenOpts.EmitSummaryIndex;
  +    bool IsThinLTO = CodeGenOpts.PrepareForThinLTO;
       bool IsLTO = CodeGenOpts.PrepareForLTO;
   
       if (CodeGenOpts.OptimizationLevel == 0) {
  diff --git a/lib/CodeGen/CGDebugInfo.cpp b/lib/CodeGen/CGDebugInfo.cpp
  index db6a82b415..91f80e5739 100644
  --- a/lib/CodeGen/CGDebugInfo.cpp
  +++ b/lib/CodeGen/CGDebugInfo.cpp
  @@ -578,7 +578,7 @@ void CGDebugInfo::CreateCompileUnit() {
                             CSInfo,
                             getSource(SM, SM.getMainFileID())),
         CGOpts.EmitVersionIdentMetadata ? Producer : "",
  -      LO.Optimize || CGOpts.PrepareForLTO || CGOpts.EmitSummaryIndex,
  +      LO.Optimize || CGOpts.PrepareForLTO || CGOpts.PrepareForThinLTO,
         CGOpts.DwarfDebugFlags, RuntimeVers,
         CGOpts.EnableSplitDwarf ? "" : CGOpts.SplitDwarfFile, EmissionKind,
         0 /* DWOid */, CGOpts.SplitDwarfInlining, CGOpts.DebugInfoForProfiling,

Are you still interested in landing this?


https://reviews.llvm.org/D34156