[PATCH] D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 7 07:01:38 PDT 2018


aaron.ballman added a comment.

In https://reviews.llvm.org/D47290#1124956, @hans wrote:

> In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D47290#1124866, @hans wrote:
> >
> > > If we really want to special-case NSInteger, and given that you're targeting a specific wide-spread pattern maybe that's the right thing to do, I think we should make -Wformat accept (move the warning behind -Wformat-pedantic I suppose) printing NSInteger with *any* integral type of the right size, not just size_t.
> >
> >
> > Would you be similarly okay with %ld and %d on Windows platforms when mixing up int and long?
>
>
> No, I'm against a general relaxation of -Wformat, but to solve JF's problem I think special-casing NSInteger might be reasonable.


How is JF's problem different?


Repository:
  rC Clang

https://reviews.llvm.org/D47290





More information about the cfe-commits mailing list