[PATCH] D47871: [clangd] Code completion: drop explicit injected names/operators, ignore Sema priority

[Eric Liu via Phabricator via cfe-commits]

ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/CodeComplete.cpp:542
         continue;
-      // Destructor completion is rarely useful, and works inconsistently.
-      // (s.^ completes ~string, but s.~st^ is an error).
-      if (dyn_cast_or_null<CXXDestructorDecl>(Result.Declaration))
+      if (Result.Declaration && !Context.getBaseType().isNull() &&
+          isBlacklistedMember(*Result.Declaration))
----------------
`!Context.getBaseType().isNull()`  probably deserves a comment. 


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D47871