[PATCH] D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.
Filipe Cabecinhas via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 6 04:40:34 PDT 2018
filcab added a comment.
I have a minor nit + what Paul mentioned (missing a `-NOT` check). Otherwise LGTM.
================
Comment at: lib/Driver/ToolChains/Clang.cpp:3690
- // Add runtime flag for PS4 when PGO or Coverage are enabled.
- if (RawTriple.isPS4CPU())
+ // Add runtime flag for PS4 when PGO or Coverage or sanitizers are enabled.
+ if (RawTriple.isPS4CPU()) {
----------------
Nit: `PGO, coverage, or sanitizers`
Repository:
rC Clang
https://reviews.llvm.org/D47375
More information about the cfe-commits
mailing list