[PATCH] D47757: [Sema] Diagnose unavailable aligned deallocation functions called from deleting destructors.

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added a comment.

I think we should sink the `DiagnoseUnavailableAlignedAllocation` into `DiagnoseUseOfDecl`, and then adds call's in the few places they're needed. Most paths we care about already pass through there.



================
Comment at: include/clang/Sema/Sema.h:5169
 
+  void diagnoseUnavailableAlignedAllocation(const FunctionDecl &FD,
+                                            SourceLocation Loc, bool IsDelete);
----------------
`DiagnoseUnavailableAlignedAllocation`.

Also, I think we can drop the `IsDelete` parameter and instead deduce it using `FD.getDeclName().getCXXOverloadedOperator()`.


Repository:
  rC Clang

https://reviews.llvm.org/D47757