[PATCH] D47267: [UnrollAndJam] Add unroll_and_jam pragma handling

Dave Green via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 5 15:04:59 PDT 2018


dmgreen added a comment.

I quite like the UnrollAndFuse naming. I'd not heard that the xlc compiler called it that. The UnrollAndJam pass was origin named that before I renamed for similar reasons (UnrollAndJam being more well known).

I see your point about the mix of underscores. "nounroll_and_jam" also comes from the Intel docs, and theres already "nounroll" vs "unroll". The "no" becomes a qualifier on "unroll_and_jam". "no_unroll_and_jam" feels less consistent to me.

But if you have a strong opinion, I'm happy enough to change it.


https://reviews.llvm.org/D47267





More information about the cfe-commits mailing list