[PATCH] D47787: [clangd] Adjust symbol score based on crude symbol type.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 5 10:49:43 PDT 2018
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: clangd/Quality.cpp:33
+static SymbolQualitySignals::SymbolCategory categorize(const NamedDecl &ND) {
+ class Switch
----------------
Have you considered `index::getSymbolInfo(ND)` and reusing the other `categorize`?
================
Comment at: clangd/Quality.cpp:51
+ MAP(FunctionTemplateDecl, Function);
+ MAP(Decl, Unknown);
+ };
----------------
ni: `#undefine MAP`?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47787
More information about the cfe-commits
mailing list