[clang-tools-extra] r333994 - [clang-tidy] fix broken test (no compile command) from r331763

[Roman Lebedev via cfe-commits]

This is strange.

First, i'm pretty sure the test worked for me before.
Second, this commit actually *breaks* those two tests for me:

$ ninja check-clang-tools
[0/1] Running the Clang extra tools' regression tests
FAIL: Clang Tools ::
clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp (123 of 867)
******************** TEST 'Clang Tools ::
clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp' FAILED
********************
Script:
--
: 'RUN: at line 1';   clang-tidy -enable-check-profile
-checks='-*,readability-function-size'
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp
-- 2>&1 | FileCheck --match-full-lines
-implicit-check-not='{{warning:|error:}}' /build/clang
-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp
--
Exit Code: 2

Command Output (stderr):
--
FileCheck error: '-' is empty.
FileCheck command line:  FileCheck --match-full-lines
-implicit-check-not={{warning:|error:}}
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp

--

********************
FAIL: Clang Tools ::
clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp (125 of 867)
******************** TEST 'Clang Tools ::
clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp' FAILED
********************
Script:
--
: 'RUN: at line 1';   clang-tidy -enable-check-profile
-checks='-*,readability-function-size'
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp
-- 2>&1 |
FileCheck --match-full-lines -implicit-check-not='{{warning:|error:}}'
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp
--
Exit Code: 2

Command Output (stderr):
--
FileCheck error: '-' is empty.
FileCheck command line:  FileCheck --match-full-lines
-implicit-check-not={{warning:|error:}}
/build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp

--

Roman.

On Tue, Jun 5, 2018 at 12:42 PM, Sam McCall via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> Author: sammccall
> Date: Tue Jun  5 02:42:06 2018
> New Revision: 333994
>
> URL: http://llvm.org/viewvc/llvm-project?rev=333994&view=rev
> Log:
> [clang-tidy] fix broken test (no compile command) from r331763
>
> Modified:
>     clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp
>     clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp
>
> Modified: clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp
> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp?rev=333994&r1=333993&r2=333994&view=diff
> ==============================================================================
> --- clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp (original)
> +++ clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp Tue Jun  5 02:42:06 2018
> @@ -1,4 +1,4 @@
> -// RUN: clang-tidy -enable-check-profile -checks='-*,readability-function-size' %s 2>&1 | FileCheck --match-full-lines -implicit-check-not='{{warning:|error:}}' %s
> +// RUN: clang-tidy -enable-check-profile -checks='-*,readability-function-size' %s -- 2>&1 | FileCheck --match-full-lines -implicit-check-not='{{warning:|error:}}' %s
>
>  // CHECK: ===-------------------------------------------------------------------------===
>  // CHECK-NEXT: {{.*}}  --- Name ---
>
> Modified: clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp
> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp?rev=333994&r1=333993&r2=333994&view=diff
> ==============================================================================
> --- clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp (original)
> +++ clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp Tue Jun  5 02:42:06 2018
> @@ -1,4 +1,4 @@
> -// RUN: clang-tidy -enable-check-profile -checks='-*,readability-function-size' %s %s 2>&1 | FileCheck --match-full-lines -implicit-check-not='{{warning:|error:}}' %s
> +// RUN: clang-tidy -enable-check-profile -checks='-*,readability-function-size' %s %s -- 2>&1 | FileCheck --match-full-lines -implicit-check-not='{{warning:|error:}}' %s
>
>  // CHECK: ===-------------------------------------------------------------------------===
>  // CHECK-NEXT: {{.*}}  --- Name ---
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits