[PATCH] D43667: [clang-doc] Implement a YAML generator

[Eric Liu via Phabricator via cfe-commits]

ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: clang-doc/Generators.h:25
+//
+// Derived classes must implement the generate*ForInfo methods, which should
+// emit documentation for the specified info in the relevant format. This is
----------------
ioeric wrote:
> nit: This seems a bit redundant as the virtual method has been set to 0. 
Oops, sorry, I only meant the first sentence; the second sentence (" ... expected to be implement and exposed ...") is still useful.


================
Comment at: clang-doc/Representation.h:198
   llvm::SmallVector<FieldTypeInfo, 4> Params;        // List of parameters.
   AccessSpecifier Access = AccessSpecifier::AS_none; // Access level for this
                                                      // method (public, private,
----------------
nit: maybe just put comment in a separate line.


================
Comment at: clang-doc/YAMLGenerator.cpp:265
+// and thus register the generator.
+volatile int YAMLGeneratorAnchorSource = 0;
+
----------------
nit: add `static`?


https://reviews.llvm.org/D43667