[PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 5 00:42:44 PDT 2018


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from a minor commenting nit, this LGTM.



================
Comment at: clang-tidy/utils/ExprMutationAnalyzer.cpp:78-81
+  // TODO: also handle these cases:
+  // - `Exp` is the ControllingExpr of a GenericSelectionExpr
+  // - `Exp` is within an expression (other than glvalue of a polymorphic class
+  //    type) operand of typeid.
----------------
I think this comment is stale now.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45679





More information about the cfe-commits mailing list