[PATCH] D47564: [Parse] Use CapturedStmt for @finally on MSVC

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 4 12:50:27 PDT 2018


smeenai added a comment.

In https://reviews.llvm.org/D47564#1119925, @rjmccall wrote:

> In https://reviews.llvm.org/D47564#1119874, @smeenai wrote:
>
> > In https://reviews.llvm.org/D47564#1118424, @rjmccall wrote:
> >
> > > No, it was just a general question.  Have you gotten this to a point where it's testable?
> >
> >
> > Yup, it's been working fine in my local testing. There's one more patch that I need to put up, which actually handles doing proper codegen for @try/@catch/@finally; I'm working on cleaning that up right now.
>
>
> Okay.  And simple tests with throwing exceptions out of the `@finally` block seem to work?


Yup, it works fine. It's essentially the same as calling a function inside a catch block which throws (since the finally is modeled as a catch-all, and the finally body is outlined into a function which gets called by that catch-all).


Repository:
  rC Clang

https://reviews.llvm.org/D47564





More information about the cfe-commits mailing list