[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 4 08:06:22 PDT 2018


lebedev.ri added subscribers: dblaikie, rnk.
lebedev.ri added a comment.

In https://reviews.llvm.org/D47687#1120971, @Higuoxing wrote:

> Update with test cases :)


Thanks.

I do believe we are being overly forgiving for macros.
Sometimes that makes sense, sometimes not, especially there is no pre-existing test.

In other words i //think// this patch has a point.
But i'll leave the actual review for others..


https://reviews.llvm.org/D47687





More information about the cfe-commits mailing list